Containers of Duplicated Analyses are not found. #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Mar 2, 2018
bika/lims/content/worksheet.py
Outdated
| @@ -502,7 +502,7 @@ def _add_duplicate(self, src_analysis, destination_slot, refgid=None): | |||
| layout = self.getLayout() | |||
| dup_pos = {'position': destination_slot, | |||
| 'type': 'd', | |||
| 'container_uid': duplicate.getRequestID(), | |||
| 'container_uid': duplicate.getRequest().UID(), | |||
There was a problem hiding this comment.
Better duplicate.getRequestUID(): https://github.com/senaite/senaite.core/blob/master/bika/lims/content/abstractroutineanalysis.py#L165-L171
xispa
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior before PR
When adding a Duplicate Analysis to a Worksheet, it saves
RequestIDinstead ofUIDto 'container_uid' field.Desired behavior after PR is merged
Set
AR UIDinstead ofID.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.