Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic sticker printing work with 'registered' option activated #720

Merged
merged 4 commits into from
Mar 13, 2018
Merged

Make automatic sticker printing work with 'registered' option activated #720

merged 4 commits into from
Mar 13, 2018

Conversation

juangallostra
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #686

Current behavior before PR

When selecting 'register' status for automatic sticker printing stickers and successfully creating some ARs Stickers do not get printed.

Desired behavior after PR is merged

If the option 'register' is selected for automatic sticker printing and some ARs are successfully created then the stickers get automatically printed.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juan, Python dictionaries are unsorted. Therefore, the final list of ARs will be unsorted and the stickers appear in arbitrary order.
But the fix is easy, just use collections.OrderedDict;)

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@ramonski ramonski merged commit bac9a65 into senaite:master Mar 13, 2018
@juangallostra juangallostra deleted the sticker-printing-on-register branch March 22, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants