Traceback in Statement view

[juangallostra]

Description of the issue/feature this PR addresses

Linked issue: #733

Current behavior before PR

When navigating to the Statement's list and trying to access a Statement an error is raised. Furthermore, the traceback appears on the page the user is viewing.

The traceback of the error is:

Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module bika.lims.browser.bika_listing, line 578, in __call__
  Module Products.Five.browser.pagetemplatefile, line 125, in __call__
  Module Products.Five.browser.pagetemplatefile, line 59, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 98, in __call__
  Module z3c.pt.pagetemplate, line 158, in render
  Module chameleon.zpt.template, line 297, in render
  Module chameleon.template, line 191, in render
  Module chameleon.template, line 171, in render
  Module 7bc87a6cf00fb809870833bf3d328b00.py, line 443, in render
  Module ec3432c014db494cdf6ac1d157ed2259.py, line 1449, in render_master
  Module ec3432c014db494cdf6ac1d157ed2259.py, line 604, in render_content
  Module 7bc87a6cf00fb809870833bf3d328b00.py, line 364, in __fill_content_core
  Module five.pt.expressions, line 161, in __call__
  Module bika.lims.browser.bika_listing, line 1569, in contents_table
  Module bika.lims.browser.bika_listing, line 1747, in __init__
  Module bika.lims.browser.invoicebatch, line 98, in folderitems
AttributeError: getClient

Desired behavior after PR is merged

No traceback appears and the invoices are listed.

Screenshot (optional)

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

[xispa]

Some very small changes. Thanks!

[xispa]

Better to remove number_link and use get_link from utils directly:

item['replace']['id'] = get_link(api.get_url(obj), obj.getId())

[xispa]

Again, better use get_link

[xispa]

Since you are using the client object in several places later, I suggest to use a local var to store the client:

client = obj.getClient()
if client:
    [...]

and use it later instead of obj.getClient()

[xispa]

Better use get_email_link from utils:

item['replace']['email'] = get_email_link(client.getEmailAddress())