Batch Label Creation/Editing error: zope.traversing.namespace.view

[juangallostra]

Description of the issue/feature this PR addresses

Linked issue: #590

Current behavior before PR

For Batch Labels, both when:

• Clicking Save after creating a new one
• Clicking on the title of one of them in the Batch Labels listing (under bika Setup / Batch Labels)

the browser refreshes a blank page with the text:
<zope.traversing.namespace.view object at 0x7fdf19e00550>

Desired behavior after PR is merged

In both cases the user is redirected to the Edit page of the Batch Label and the message showed in the previous section does not appear.

Notes (Please read):

1. Issue Batch label create error zope.traversing.namespace.view #590 suggests redirecting to Batch Labels' listing view. However, after inspecting some of the other areas (AR Templates, Analysis Categories, Analysis Profiles, Analysis Services, Analysis Specifications, Attachment Types), I've noticed that all of them redirect after creation to the respective Edit view. So the changes included in this PR apply the same behavior to Batch Labels

2. I don't know if I missed something, but for the change to be effective I had to setup a new instance. I wasn't able to find a way to make it work with an already installed instance. Can the xml files under profiles/default/types be reloaded in someway?

3. There is another possible approach which is to:
   3.1 In order to solve the editing problem: Modify in bika_batchlabels.py, line 67, the piece of code items[x]['url'] by '/'.join([items[x]['url'], 'edit']) so as to redirect when clicking the Title to the Batch Label's edit view.
   

   senaite.core/bika/lims/controlpanel/bika_batchlabels.py

   Lines 66 to 67 in ef7c16f

   	items[x]['replace']['Title'] = "<a href='%s'>%s</a>" % \
   	(items[x]['url'], items[x]['Title'])

   
   3.2 Change also the behavior of the Save button to redirect either to the Edit view or the listing.

   @xispa @ramonski Maybe this second approach is better?

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

[ramonski]

Awesome, thanks Juan!

[ramonski]

Hi Juan, I tested your approach on https://senaite.ridingbytes.com, and it seems to work perfectly:

However, I was too quick accepting this PR, because the type XML's are not run automatically and need an upgrade step.
Basically that upgrade step fetches the portal_types tool and set the value programatically.

Regarding your questions above, I think your approach is the least invasive change and I would therefor prefer it over the other ones.

Thanks!