Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink Analyses on ARs to their WSs if assigned #775

Merged
merged 3 commits into from
Apr 20, 2018
Merged

Hyperlink Analyses on ARs to their WSs if assigned #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ac2ef3
Fix conditional check that looks for non analysis requests
Apr 20, 2018
8766a98
Update CHANGES.rst
Apr 20, 2018
831c147
Merge branch 'master' into worksheet-icon-analysis
juangallostra Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Changelog

**Removed**


**Fixed**

- #775 Analyses on Analysis Requests are hyperlinked to their Worksheets
- #769 Traceback when submitting duplicate when Duplicate Variation is not set
- #771 Slow Searches in Listing Views
- #774 When retracting an Analysis Requests its analyses are also retracted
Expand Down
2 changes: 1 addition & 1 deletion bika/lims/browser/analyses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ def _folder_item_assigned_worksheet(self, analysis_brain, item):
:param analysis_brain: Brain that represents an analysis
:param item: analysis' dictionary counterpart that represents a row
"""
if IAnalysisRequest.providedBy(self.context):
if not IAnalysisRequest.providedBy(self.context):
# We want this icon to only appear if the context is an AR
return

Expand Down