Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove senaite.api import #811

Merged
merged 2 commits into from
May 4, 2018
Merged

Remove senaite.api import #811

merged 2 commits into from
May 4, 2018

Conversation

juangallostra
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #810

Current behavior before PR

Travis fails when trying to import senaite api with the following traceback:

File "/home/travis/build/senaite/senaite.core/bika/lims/browser/sample/__init__.py", line 13, in <module>
   from .printform import SamplesPrint
 File "/home/travis/build/senaite/senaite.core/bika/lims/browser/sample/printform.py", line 15, in <module>
   from senaite import api
ZopeXMLConfigurationError: File "/home/travis/build/senaite/senaite.core/bika/lims/configure.zcml", line 29.2-29.32
   ZopeXMLConfigurationError: File "/home/travis/build/senaite/senaite.core/bika/lims/browser/configure.zcml", line 41.2-41.42
   ImportError: No module named senaite

Desired behavior after PR is merged

Travis is happy again (Travis is hard to please)

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa merged commit e0fcea6 into senaite:master May 4, 2018
@juangallostra juangallostra deleted the remove-senaite-api-import branch July 5, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants