Error when exporting Worksheets list with senaite.exporter #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`senaite.exporter` directly calls to filderitems function from the view that implements BikaListing. Thus, if some variables that haven't been initialized before are useed there, a Traceback is rised: Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module senaite.exporter.list_exporters, line 48, in __call__ Module senaite.exporter.list_exporters, line 131, in export_to_list Module senaite.exporter.list_exporters, line 152, in get_items Module bika.lims.browser.worksheet.views.folder, line 326, in folderitems Module bika.lims.browser.bika_listing, line 932, in folderitems Module bika.lims.browser.worksheet.views.folder, line 255, in isItemAllowed AttributeError: 'FolderView' object has no attribute 'selected_state' As a good practice, class variables should always be initialized in the class constructor __init__, and this commit does it. As a colateral effect, exporter works without rising any error.
ramonski
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
senaite.exporterdirectly calls to filderitems function from the view that implements BikaListing. Thus, if some variables that haven't been initialized before are useed there, a Traceback is rised.As a good practice, class variables should always be initialized in the class constructor init, and this commit does it. As a colateral effect, exporter works without rising any error.
Current behavior before PR
The following Trace is rised:
Desired behavior after PR is merged
The list of worksheets gets exported without errors
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.