ACP-22 Adapter to make the generation of custom IDs easier #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Espurna
reviewed
May 5, 2017
bika/lims/idserver.py
Outdated
| # Checking if an adapter exists for this content type. If yes, we will | ||
| # get new_id from adapter. | ||
| for name, adapter in getAdapters((obj, ), IIdServer): | ||
| new_id = adapter.generate_id(obj.portal_type) |
There was a problem hiding this comment.
It would be a good idea to add a log if more than one adapters are found.
Something like that should be enough
for name, adapter in getAdapters((obj, ), IIdServer):
if new_id is not None:
logger.warn('More than one id server adapters found for {} content type.'.format(obj.gettype()))
new_id = adapter.generate_id(obj.portal_type)
Espurna
approved these changes
May 9, 2017
xispa
changed the title
Ruhanga
pushed a commit
to Ruhanga/senaite.core
that referenced
this pull request
Mar 14, 2022
* client field in doctor * Adding doctors acction for client portal_type * doctors view added for client folder * added index to filter doctors by clients * permissions to view doctors * add permissions * fixing import error * using bika api * easier to understand sort * logger outside the loop * docstring * docstring * docstring * Reindex doctors folder to update permissions * better performant get_client method * improving upgradestep * remove propertiestool * Fixed error because of missing Value for allowedRolesAndUsers * Update CHANGES.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To override ID generators, added adapter control to renameAfterCreation function in idserver. So, if an object has an adapter providing IIdServer from bika.lims.interfaces, then it will call its generate_id method right after it is created to rename it.