Unpinned WeasyPrint to allow Addon to use newer version #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
May 22, 2018
There was a problem hiding this comment.
Please, add a comment like "This update requires the execution of bin/buildout, because ..." in RELEASE_NOTES.rst. See update 1.2.3 to 1.2.4 https://github.com/senaite/senaite.core/blob/master/RELEASE_NOTES.rst#update-from-123-to-124
|
I thought about that as well, but I think most of the people should be fine with 0.42.2. So unless 0.42.3 or any greater version gives us a real advantage over any older version, I would keep that change silently... |
|
Understand, ssince we don't add anything in the code that depends on the new version of weasyprint. then no need to warn the user for something that will not have any impact. Accepting. |
xispa
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
WeasyPrint is currently pinned to
0.42.2. It is not possible for Add-ons to use e.g.0.42.3because of that version constraint.Anyhow, we should go with the latest versions of WeasyPrint...
Current behavior before PR
WeasyPrint pinned to
0.42.2Desired behavior after PR is merged
WeasyPrint unpinned. Newest version is fetched (currently
0.42.3)--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.