Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed remarks.zcml #930

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Removed remarks.zcml #930

merged 1 commit into from
Jul 27, 2018

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This line was removed as of #920 and came accidently in again as of #913.

No changelog for this needed.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa July 27, 2018 18:45
xispa
xispa approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, thanks @ramonski I was the one who merged #913 and did not recall about this line. I think #913 wasm at some point, forked from #920 or something and this nut did not fall apart.

@xispa xispa merged commit 72e5d53 into master Jul 27, 2018
@xispa xispa deleted the remove-remarks-zcml branch August 11, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xispa xispa xispa approved these changes

Assignees
No one assigned
Labels
Bug 🐞 P0: Critical
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonski @xispa