-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance. Analysis structure and relationship with Analysis Service refactored #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very simple uid-based reference field which stores a UID or a list of UIDS as strings in the zodb, and reconstitutes them to objects when retrieved. It does not support backreferences, or link integrity (holdingreference) but it also does not require the overhead of AT References which is prohibitive for our use-case.
PEP8, cleanup, comments, and make the schemas and the migration cooperate with each other
- Analysis.getService() is deprecated, and has been removed - Some catalog columns in bika_analysis_catalog are removed - Some small pep8 and cleaning up.
Down to AbstractAnalysis, then to AbstractRoutineAnalysis AbstractBaseAnalysis -> AbstractAnalysis, AnalysisService AbstractAnalysis -> AbstractRoutineAnalysis, ReferenceAnalysis AbstractRoutineAnalysis -> Analysis, DuplicateAnalysis, RejectAnalysis Lots of little refactoring as I went along.
Just added workflow call directly into the only template that uses it.
# Conflicts: # bika/lims/content/analysisrequest.py # bika/lims/upgrade/v3_2_0_1705.py
ServiceUID is derived from the AnalysisService reference, not the other way around.
5401133
to
73c0670
Compare
44afb54
to
c9b2099
Compare
There is no need to add these methods because are inherited from AbstractAnalysis already.
Inherited from AbstractAnalysis already
Methods inherited from AbstractAnalysis already
Requires migration, to fix catalogs and remove the setup objects
# Conflicts: # bika/lims/content/referenceanalysis.py # bika/lims/upgrade/utils.py # bika/lims/upgrade/v3_2_0_1705.py
…nto HistoryAwareReferenceField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relationship between AnalysisService and the various types of
Analysis has been refactored. The class heirarchy now looks like this: