Enable flake8 on Travis CI #48
Conversation
| script: | ||
| - bin/flake8 --config travis_ci_flake8.cfg src/ |
There was a problem hiding this comment.
it looks like Travis CI currently doesn't run on pull requests, so this change is not tested
There was a problem hiding this comment.
At least we can run it manually against the configuration, so no worries.
| [flake8] | ||
| # temporarily disable violations for existing code until they are cleaned up | ||
| extend-ignore = | ||
| # E501: line too long |
There was a problem hiding this comment.
This has roughly 60 violations, so I didn't want to clean them up in this pull request. Does this project generally stick to the 79 characters limit?
There was a problem hiding this comment.
Hi @winniehell, thanks for all your efforts in cleaning up the codebases.
Yes, it should actually stick to the 79 characters limit, but I'm not sure with the route decorators, which might exceed this limit here and there...
|
@ramonski you may have missed this pull request. can I ask you to take a look? |
Description of the issue/feature this PR addresses
Enables automated flake8 check in Travis CI and fixes existing violations.
see also senaite/senaite.core#2077