This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Empty user e-mails. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
suggested changes
Mar 8, 2018
src/senaite/sync/importstep.py
Outdated
| @@ -168,6 +168,8 @@ def _import_users(self): | |||
| logger.debug("Skipping existing user {}".format(username)) | |||
| continue | |||
| email = user.get("email", "") | |||
| if not email: | |||
| email = "[email protected]" | |||
There was a problem hiding this comment.
Please, add at least a comment why you need to setup a "fake" email to the user. As per the accepted answer here https://stackoverflow.com/questions/1368163/is-there-a-standard-domain-for-testing-throwaway-email , seems that using example.com as domain is fine for testing purposes. I'd just only do the following change:
email = "{}@example.com".format(username)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
If a user doesn't have any e-mail set in the source, then system fails to create that user in the destination.
Expected behavior after this PR
If a user doesn't have an e-mail set, set it to default value-
[email protected].