This repository was archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
New Advanced Configuration Options #42
Merged
+609
−292
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e1977b4
Rename a column in the Souper: 'path' --> 'remote_path'.
nihadness 0822a51
Do not fail if local path is not set while inserting to Souper.
nihadness 95bd992
Path Translator with prefix.
nihadness 522d9d2
Use prefixes in object and parent creation.
nihadness ecb6c18
Use new local ID while creating parents.
nihadness e62d580
Separated 'Add' and 'Show' views of Remotes.
nihadness d182d3b
Introduction to Prefix Logic in import Step.
nihadness d26222d
Return string values while getting local paths.
nihadness d34b423
Do not touch ID while updating object data.
nihadness 183ac97
Content Types to be created with prefix in the 'Add Remote' View.
nihadness ffc6219
Raise SyncError if record not found in the Souper table.
nihadness 8c64034
Validate Prefix if Prefixable Types Introduced.
nihadness ea66944
Polish.
nihadness b5af958
Unwanted Portal Types in 'Add Remote' View.
nihadness 5e6bea6
Generic 'is_item_allowed' method.
nihadness 8c3cb5f
'None' --> '[]'
nihadness 54ad0e1
Quick Fix.
nihadness 7fb93f9
Polish & Comments
nihadness 3830b01
Raise SyncError if Remote Path is empty in a Souper Record.
nihadness 734bfcf
Front End.
nihadness 3502310
Polish.
nihadness 4af828c
'Senaite.Lims' compatibility.
nihadness 2f6dda4
Changes.rst
nihadness ac6210b
Remove forgotten pdb.
nihadness 9c8841b
Uncomment error catch.
nihadness bc77d58
Review Changes.
nihadness 431886d
Polish.
nihadness 2c7e107
Review Change.
nihadness File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Unwanted Portal Types in 'Add Remote' View.
commit b5af958ec723bd0527bb83cb5b647e827feb3135
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to reduce a bit the complexity by adding a function to get the content types:
So, you'll only need to do the following here:
Note with this change you'll be able to remove the logic for
prefixable_types
below.