This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Long term infinite loops in Update Step #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although the last commit is not only about update step, I pushed in to this PR since it is just a missing |
xispa
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior before PR
If two instances are synchronized and there are objects that are updated on one of the instances, then these objects will be handled in Sync processes from both sides forever. It happens because while synchronizing from the source, in the destination instance 'modified' time gets updated. Later when the source runs Sync, the destination sends these objects as recently modified objects and so on.
Desired behavior after PR is merged
Modification times are not 'overriden' in Update Step, so only local changes will be sent to Remotes.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.