Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added sqlite. Fixes #19 #20

Merged
merged 4 commits into from
Mar 21, 2022
Merged

feature: added sqlite. Fixes #19 #20

merged 4 commits into from
Mar 21, 2022

Conversation

swampie
Copy link
Member

@swampie swampie commented Mar 17, 2022

This PR adds the drivers and the support for sqlite databases

@pditommaso
Copy link
Contributor

This is nice. What about adding a test for the binary version like this so we are sure the compile version works?

@swampie
Copy link
Member Author

swampie commented Mar 18, 2022

This is nice. What about adding a test for the binary version like this so we are sure the compile version works?

Native test running as we speak

@pditommaso
Copy link
Contributor

Task :nativeCliTest

SqliteTest > should run native binary FAILED
java.lang.ArrayStoreException at SqliteTest.groovy:33

@swampie
Copy link
Member Author

swampie commented Mar 18, 2022

I love GraalVM

@jorgeaguileraseqera
Copy link
Contributor

It's not a graalvm error,

change this line
--url', "jdbc:sqlite:${this.dbName}"
by

'--url', "jdbc:sqlite:${this.dbName}".toString(),

@jorgeaguileraseqera
Copy link
Contributor

also, I don't know why, you need to specify the driver ( '--driver','org.h2.Driver',) in command-line arguments

maybe we are missing to include some dependency

@pditommaso
Copy link
Contributor

Actually it should be needed. sqlite should be added here

http://github.com/seqeralabs/migtool/blob/0a1d13300d62666d956e404b5ea0f1f6100fd9e8/src/main/java/io/seqera/migtool/Helper.java#L204-L218

@pditommaso
Copy link
Contributor

Let's invoke @jorgeaguileraseqera superpower for this build issue

@pditommaso
Copy link
Contributor

The graal guru strike again 😄

@jorgeaguileraseqera
Copy link
Contributor

stackoverflow superpower

btw I founded we're initilizing the dialect to mysql always

@pditommaso
Copy link
Contributor

btw I founded we're initilizing the dialect to mysql always

What do you mean?

@jorgeaguileraseqera
Copy link
Contributor

sorry:

at https://github.com/seqeralabs/migtool/pull/20/files#diff-d5a5ef22be862b9bb4e634ed65a40cfda20d8302fd85b238519a9aecb2607601R32

we init the dialect by the default to mysql so if not set by command line we use mysql and never extracted from the url

@swampie
Copy link
Member Author

swampie commented Mar 21, 2022

Is this version releasable? @pditommaso

@pditommaso pditommaso merged commit 1bda8c4 into master Mar 21, 2022
@pditommaso pditommaso deleted the issue_19_add_sqlite branch March 21, 2022 13:37
@pditommaso
Copy link
Contributor

Looks so merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants