Reverts compatibility of compileJava to 11 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgeadas
commented
Jan 24, 2024
pgeadas
commented
- @weronikasosnowskaseqera mentioned that some other projects might be using this tool with Java 11, so I revert this back until I am sure it is safe to update
If we want to upgrade to Micronaut 4.x, I'm afraid Java 17 is mandatory. In principle, those projects should be using a fixed version that works for Java 11. |
|
Indeed. But support for MN is a separate effort. Merging this for the sake of compatibility with existing projects |
|
So should we leave it as 17 already and update the other projects to use 17? |
Apart from Tower (and as far as I know):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.