Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix duplicate name bug #127

Merged
merged 3 commits into from
Mar 19, 2024
Merged

fix: fix duplicate name bug #127

merged 3 commits into from
Mar 19, 2024

Conversation

ejseqera
Copy link
Member

@ejseqera ejseqera commented Mar 18, 2024

Re #123

  • Fixes method used to identify value associated with name key or --name argument and use value to identify duplicates
  • Disable any usage of overwrite method with --dryrun

Test with a yaml defining teams as following:

teams:
  - name: "launchers"
    organization: "myorg"
    description: "Users with launcher permissions"
    overwrite: true
    members:
      - [email protected]
  - name: "viewers"
    organization: "myorg"
    description: "Users with viewer permissions"
    overwrite: true
    members:
      - [email protected]

Where running seqerakit will correctly provide dryrun output:

$ seqerakit teams.yaml --dryrun
DEBUG:root:DRYRUN: Running command tw teams add --name launchers --organization myorg --description 'Users with launcher permissions'
DEBUG:root:DRYRUN: Running command tw teams members --team launchers --organization myorg add --member [email protected]
DEBUG:root:DRYRUN: Running command tw teams add --name viewers --organization myorg --description 'Users with viewer permissions'
DEBUG:root:DRYRUN: Running command tw teams members --team viewers --organization myorg add --member [email protected]

@ejseqera ejseqera merged commit 6329783 into dev Mar 19, 2024
2 checks passed
@ejseqera ejseqera deleted the 126-wrong-duplicate-detection branch March 19, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant