Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniqueness bug with dicts using keys other than name #132

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

ejseqera
Copy link
Member

Found with adding members, the result from find_name() returned none because the --name key does not exist.

Resolved with defining keys to check membership for in items with strings or lists. Test with:

members:
   - user: '[email protected]'
     organization: '$TOWER_ORG_NAME'
     overwrite: True
   - user: '[email protected]'
     organization: '$TOWER_ORG_NAME'
     overwrite: True

Where dryrun returns:

DEBUG:root:DRYRUN: Running command tw members add --user [email protected] --organization $TOWER_ORG_NAME
DEBUG:root:DRYRUN: Running command tw members add --user [email protected] --organization $TOWER_ORG_NAME

@ejseqera ejseqera merged commit b5b910e into dev Mar 21, 2024
2 checks passed
@ejseqera ejseqera deleted the fix-uniqueness-bug branch March 21, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant