Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling for overwrite class without json output #172

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ejseqera
Copy link
Member

@ejseqera ejseqera commented Dec 3, 2024

Fixes #170.

  • Creates a separate instance of the SeqeraPlatform class for Overwrite to inherit without using the JSON option so we don't double up on -o json. The Overwrite class handles emitting output to JSON natively so we don't need this handling.
  • Modified _execute_command to respect print_stdout setting when JSON output is enabled. Previously, stdout would always be printed when processing JSON output, regardless of the print_stdout flag. This change ensures consistent behavior between JSON and non-JSON output modes.

@ejseqera ejseqera requested a review from adamrtalbot December 3, 2024 03:03
Co-authored-by: Adam Talbot <[email protected]>
@ejseqera ejseqera merged commit d6424f9 into dev Dec 3, 2024
2 checks passed
@ejseqera ejseqera deleted the fix-overwrite-to-json branch December 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants