Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-1242 - Add DataStudio start command. #477

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

georgi-seqera
Copy link
Contributor

@georgi-seqera georgi-seqera commented Jan 23, 2025

Context

Work relates to task: https://seqera.atlassian.net/browse/PLAT-1242

Summary: add the ability to start a data studio via the CLI.
Optionality to:

  • override/update any of the existing DataStudio configurations (gpu, cpu, mountData, etc.) or description
  • have command wait for specific status of DataStudio

Testing

Trigger a start (default asyncrounous command):

$ ./tw studios start -w 27230932650799 -i 6c74268d

  Data Studio 6c74268d START successfully submitted at [data-studios / data-studios] workspace.

     https://dev-tower.net/orgs/data-studios/workspaces/data-studios/studios/6c74268d/connect
REC-20250123124017.mp4

Trigger a start with override configuration supplied

$ ./tw studios start -w 27230932650799 -i 6c74268d --description 'Override test description' --cpu 4

  Data Studio 6c74268d START successfully submitted at [data-studios / data-studios] workspace.

     https://dev-tower.net/orgs/data-studios/workspaces/data-studios/studios/6c74268d/connect
REC-20250123124459.mp4

Trigger a start with --wait flag to wait until desired DataStudio status is reached.

$ ./tw studios start -w 27230932650799 -i 6c74268d --wait RUNNING

  Data Studio 6c74268d START successfully submitted at [data-studios / data-studios] workspace.

     https://dev-tower.net/orgs/data-studios/workspaces/data-studios/studios/6c74268d/connect

  Waiting running status....
  Status transitioned to: starting
  Provisioning compute resources...................
  Mounted checkpoint 8 of 9
  Status transitioned to: running  [DONE]
Test.mp4

@georgi-seqera georgi-seqera marked this pull request as ready for review January 23, 2025 14:03
Copy link
Contributor

@weronikasosnowskaseqera weronikasosnowskaseqera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the address we should return is different. The one you're returning now is used by FE to load the iframe. If you go to UI and click Copy data studio URL then you will get this URL (example) http://tower.localhost:8000/orgs/org/workspaces/wsp/studios/d3bf39a8/connect

image

Copy link
Member

@endre-seqera endre-seqera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, only small comments!

@t0randr
Copy link
Contributor

t0randr commented Jan 24, 2025

Nice work.

@georgi-seqera georgi-seqera merged commit d60e842 into master Jan 24, 2025
12 checks passed
@georgi-seqera georgi-seqera deleted the PLAT-1242-add-data-studio-command-start-stop branch January 24, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants