Add S-needs-code-changes if travis build fails

eventhandler.py

@@ -10,7 +10,8 @@
     'synchronize': 'on_pr_updated',
     'created': 'on_new_comment',
     'closed': 'on_pr_closed',
-    'labeled': 'on_issue_labeled'
+    'labeled': 'on_issue_labeled',
+    'status': 'on_build_status'
 }
 
 
@@ -30,10 +31,14 @@ def on_pr_closed(self, api, payload):
     def on_issue_labeled(self, api, payload):
         pass
 
+    def on_build_status(self, api, payload):
+        pass
+
     def handle_payload(self, api, payload):
         def callback(action):
             getattr(self, _payload_actions[action])(api, payload)
-        payload_action = payload['action']
+        payload_action = 'status' if 'context' in payload \
+            else payload['action']
         linear_search(_payload_actions, payload_action, callback)
 
     def warn(self, msg):

handlers/status_update/__init__.py

@@ -45,4 +45,9 @@ def on_pr_closed(self, api, payload):
         if payload['pull_request']['merged']:
             api.remove_label("S-awaiting-merge")
 
+    def on_build_status(self, api, payload):
+        if payload['context'] == 'continuous-integration/travis-ci/pr':
+            if payload['state'] == 'failure' or payload['state'] == 'error':
+                api.add_label("S-needs-code-changes")
+
 handler_interface = StatusUpdateHandler

handlers/status_update/tests/build_status.json

@@ -0,0 +1,21 @@
+{
+  "expected": {
+    "labels": [
+      "S-needs-code-changes"
+    ]
+  },
+  "initial": {
+    "labels": []
+  },
+  "payload": {
+    "target_url": "https://travis-ci.org/servo/servo/builds/120670455",
+    "context": "continuous-integration/travis-ci/pr",
+    "repository": {
+      "owner": {
+        "login": "servo"
+      },
+      "name": "servo"
+    },
+    "state": "failure"
+  }
+}

json_cleanup.py

@@ -70,6 +70,9 @@ def __str__(self):
     def __int__(self):
         return int(self._node)
 
+    def split(self, sep):
+        return self._node.split(sep)
+
 
 class JsonCleaner(object):
     def __init__(self, json_obj):

newpr.py

@@ -15,6 +15,7 @@
 from StringIO import StringIO
 import urllib2
 
+from travisciapiprovider import TravisCiApiProvider
 import eventhandler
 
 
@@ -215,7 +216,14 @@ def get_page_content(self, url):
 
 
 def extract_globals_from_payload(payload):
-    if payload["action"] == "created" or payload["action"] == "labeled":
+    if 'context' in payload:
+        owner = payload['repository']['owner']['login']
+        repo = payload['repository']['name']
+        travis = TravisCiApiProvider()
+        build_number = payload['target_url'].split('/')[-1]
+        build = travis.get_build(build_number)
+        issue = travis.get_pull_request_number(build)
+    elif payload['action'] == 'created' or payload['action'] == 'labeled':
         owner = payload['repository']['owner']['login']
         repo = payload['repository']['name']
         issue = str(payload['issue']['number'])

travisciapiprovider.py

@@ -0,0 +1,15 @@
+import urllib
+import json
+
+
+class TravisCiApiProvider():
+    host_url = 'https://api.travis-ci.org'
+    build_url = host_url + '/builds/{build_id}'
+    log_url = host_url + '/jobs/{job_id}/log'
+
+    def get_build(self, build_id):
+        url = self.build_url.format(build_id=build_id)
+        return json.loads(urllib.urlopen(url).read())
+
+    def get_pull_request_number(self, build_data):
+        return int(build_data['compare_url'].split('/')[-1])