Split newpr.py into a set of dynamically-loaded event handlers #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y. Create a new test format that includes initial and expected values, causing only the listed expected values to be checked.
|
|
|
The next step after this will be to split the handlers out of the highfive repo entirely and move them to a servo-highfive repository. This should allow the Rust folks to use the same highfive codebase and write their own modules as necessary. |
|
r+ this looks great! Thank you! |
jdm
added a commit
that referenced
this pull request
Nov 30, 2015
Split newpr.py into a set of dynamically-loaded event handlers
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/highfive
that referenced
this pull request
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds per-handler tests, and adds initial state and expected output to each test file. Furthermore, test files are discovered automatically by the test harness by looking in the
tests/subdirectory of each handler, rather than relying on a declared list.r? @edunham