Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: simplify some statements for readability #563

Merged
merged 2 commits into from
Nov 30, 2024
Merged

style: simplify some statements for readability #563

merged 2 commits into from
Nov 30, 2024

Conversation

hamirmahal
Copy link
Contributor

Closes #562

hamirmahal
hamirmahal commented Nov 29, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't result in any user-facing changes.

The goal of this pull request is to improve code readability and developer productivity.

jdm
jdm approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdm jdm enabled auto-merge November 30, 2024 00:31
@jdm jdm added this pull request to the merge queue Nov 30, 2024
Merged via the queue into servo:main with commit 19cb186 Nov 30, 2024
6 checks passed
@hamirmahal hamirmahal deleted the style/simplify-some-statements-for-readability branch November 30, 2024 00:38
@hamirmahal
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some statements can be simplified for readability
2 participants
@hamirmahal @jdm