Add support for 'font-stretch' in geckolib #13570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
|
r=me if screenshots work (fwiw screenshots don't count as tests 😄, the PR text is talking about automated tests. For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons) |
|
@Manishearth Yeah, but we don't have any other tests 😄 |
|
@bors-servo r=Manishearth |
|
📌 Commit 361f372 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 4, 2016
Add support for 'font-stretch' in geckolib <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13570) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt2 |
highfive
added
S-tests-failed
bors-servo
pushed a commit
that referenced
this pull request
Oct 4, 2016
Add support for 'font-stretch' in geckolib <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13570) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
5 tasks
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
highfive
removed
the
S-awaiting-merge
1 task
bors-servo
pushed a commit
that referenced
this pull request
Oct 14, 2016
Add support for 'font-kerning' in geckolib Add support for 'font-kerning' in geckolib These changes fix #13667 $ ./mach build -d It looks like you passed an unrecognized argument into mach. $ ./mach test-tidy It looks like you are trying to run an unknown mach command: test-tidy I'm clearly doing something wrong here, but I'm not sure what - [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](#13570 (comment))" :) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13751) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 4, 2017
…m joewalker:font-kerning); r=Manishearth
Add support for 'font-kerning' in geckolib
These changes fix #13667
$ ./mach build -d
It looks like you passed an unrecognized argument into mach.
$ ./mach test-tidy
It looks like you are trying to run an unknown mach command: test-tidy
I'm clearly doing something wrong here, but I'm not sure what
- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](servo/servo#13570 (comment))" :)
Source-Repo: https://github.com/servo/servo
Source-Revision: b94f074b52584f467c61ee5d1851b1b4557ccfcb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…m joewalker:font-kerning); r=Manishearth
Add support for 'font-kerning' in geckolib
These changes fix #13667
$ ./mach build -d
It looks like you passed an unrecognized argument into mach.
$ ./mach test-tidy
It looks like you are trying to run an unknown mach command: test-tidy
I'm clearly doing something wrong here, but I'm not sure what
- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](servo/servo#13570 (comment))" :)
Source-Repo: https://github.com/servo/servo
Source-Revision: b94f074b52584f467c61ee5d1851b1b4557ccfcb
UltraBlame original commit: b1a91e2daf1e2b591e45b0931083619c89571bb1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…m joewalker:font-kerning); r=Manishearth
Add support for 'font-kerning' in geckolib
These changes fix #13667
$ ./mach build -d
It looks like you passed an unrecognized argument into mach.
$ ./mach test-tidy
It looks like you are trying to run an unknown mach command: test-tidy
I'm clearly doing something wrong here, but I'm not sure what
- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](servo/servo#13570 (comment))" :)
Source-Repo: https://github.com/servo/servo
Source-Revision: b94f074b52584f467c61ee5d1851b1b4557ccfcb
UltraBlame original commit: b1a91e2daf1e2b591e45b0931083619c89571bb1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…m joewalker:font-kerning); r=Manishearth
Add support for 'font-kerning' in geckolib
These changes fix #13667
$ ./mach build -d
It looks like you passed an unrecognized argument into mach.
$ ./mach test-tidy
It looks like you are trying to run an unknown mach command: test-tidy
I'm clearly doing something wrong here, but I'm not sure what
- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](servo/servo#13570 (comment))" :)
Source-Repo: https://github.com/servo/servo
Source-Revision: b94f074b52584f467c61ee5d1851b1b4557ccfcb
UltraBlame original commit: b1a91e2daf1e2b591e45b0931083619c89571bb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build-geckolibdoes not report any errors./mach test-tidydoes not report any errorsr? @Manishearth
This change is