Remove FromFailableIterator trait #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Aug 5, 2019
|
Seems pretty plausible to me. |
matklad
force-pushed
the
no-from-failable-iter
branch
from
3291fe3 to
daebbbb
Compare
We can use std::iter::FromIterator instead, which has the advantage of working with more types out of the box. It also tightens up the semantics a little bit, because it forbids swallowing an error.
matklad
force-pushed
the
no-from-failable-iter
branch
from
daebbbb to
dd69f13
Compare
matklad
changed the title
|
Ok, should be ready for review now! |
dpc
approved these changes
May 13, 2022
|
@sfackler are there plans to release a version that includes this change? |
|
@dpc ^ |
|
Looks like I can. I'll try to get to it soon(ish). Please ping me, even daily if I don't. |
|
@dpc ping. |
|
@tamird I've did some cleanups, landed everything, you might want to double check me if you can. hopefully will release this weekend. |
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use std::iter::FromIterator instead, which has the advantage of
working with more types out of the box. It also tightens up the
semantics a little bit, because it forbids swallowing an error.
That's just a proof of concept PR. If you are ok with the change in general, I can remove the trait completely.