Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncrementBy/decrementBy not working when using array position in attributePath #200

Closed
simonmumenthaler opened this issue Mar 26, 2019 · 1 comment · Fixed by #201
Closed

IncrementBy/decrementBy not working when using array position in attributePath #200

simonmumenthaler opened this issue Mar 26, 2019 · 1 comment · Fixed by #201
Assignees
@simonmumenthaler
Labels
bug released

Comments

@simonmumenthaler
Copy link
Contributor 

new TransactUpdate(MyModel, partitionKey, rangeKey)
  .operations( update(`myList[0]`).incrementBy(42) )

expected behaviour:
should generate UpdateExpression as follows:

{
   type: 'SET',
   statement: '#myList[0] = #myList[0] + :myList_at_0',
   attributeNames: { '#myList': 'myList' },
   attributeValues: { ':myList_at_0': { N: '42' } },
 }

actual behaviour:
throws Error: Given value must be either Array or Set 42
only updateFunction set() works with indexes in attribute path
@simonmumenthaler simonmumenthaler self-assigned this Mar 26, 2019
simonmumenthaler added a commit that referenced this issue Mar 26, 2019
@simonmumenthaler
fix(update-expression-builder): index in attribute path
9207355 
closes #200
@simonmumenthaler simonmumenthaler mentioned this issue Mar 26, 2019
Merged
simonmumenthaler added a commit that referenced this issue Mar 26, 2019
@simonmumenthaler
Merge branch 'master' into #200-array-position-in-attribute-path
5ab0c66
michaelwittwer added a commit that referenced this issue Mar 27, 2019
@michaelwittwer
Merge pull request #201 from shiftcode/#200-array-position-in-attribu…
9eb6569 
…te-path

fix(update-expression-builder): index in attribute path
@michaelwittwer
Copy link
Member

🎉 This issue has been resolved in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonmumenthaler simonmumenthaler

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(update-expression-builder): index in attribute path shiftcode/dynamo-easy
2 participants
@michaelwittwer @simonmumenthaler