-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#311 prerelease deployment #312
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure #311-prerelease-deployment branch to be published on channel pr311
don't run on pull_request, we control the publication of a branch through the .releaserc.json file, we release from a normal non master branch
- change trigger to only react on pushes and pr events for non-tags - configure some details
simonmumenthaler
approved these changes
Jun 12, 2020
simonmumenthaler
suggested changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it is not a feature - and no new version should be published: move changes to another branch without 'feat' commits...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request contains two main features:
Replace travis build with github-action build
To be able to release preview functionality via npm we can update the .releaserc.json file to allow a branch to be published, this process is for now not tied to the creation of a PR for a certain branch.
This would be the desired behavior, but for now we just allow a more manual approach.
The channel defines the
npm dist-tag
and the prerelease defines the v5.8.0-pr311.1 (bold part), those two values should always be equal.With this setup consumers are able to install prerelease version using the command
npm i @shiftcode/dynamo-easy@pr311