Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

fix: after cd, must run the specified drive letter #252

Merged
merged 6 commits into from
Sep 27, 2019

Conversation

Shenfq
Copy link
Contributor

@Shenfq Shenfq commented Sep 19, 2019

on the Windows, If my project is on the D drive(D:/projce/demo), after running cd C:/user, I will not enter the C drive immediately, we need to run C:, then we enter C:/user.

so, this PR want to fix this.

Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using path.parse function will be safer. https://nodejs.org/api/path.html

@gregberge gregberge merged commit ab916a9 into shipitjs:master Sep 27, 2019
@gregberge
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants