Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sledgehammer Bonus Damage #4284

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

generalthrax
Copy link
Contributor

About The Pull Request

Sledgehammers now deal 200 bonus damage to walls. Two hits for a normal wall and 7 for a reinforced wall, roughly. They can now also instantly destroy girders.

Why It's Good For The Game

It's not really a breaching sledgehammer if it can't breach, is it?

Changelog

🆑
add: Breaching Sledgehammer now does 200 bonus damage to walls
add: Breaching Sledgehammer now instantly destroys girders
/:cl:

actions-user and others added 21 commits October 18, 2024 01:47
@github-actions github-actions bot added the Code change Watch something violently break. label Feb 27, 2025
@DIB-DOG
Copy link
Contributor

DIB-DOG commented Feb 27, 2025

How many hits was it before this change? Even if it’s a “breaching hammer” I feel like manually beating a wall down should take the same amount of time, if not more time, than using a motorized tool like an angle grinder or a plasma cutter. The hammer should have course beat using any other object to break down a wall, but 2 hits to get through a wall feels insanely fast.

@generalthrax
Copy link
Contributor Author

How many hits was it before this change? Even if it’s a “breaching hammer” I feel like manually beating a wall down should take the same amount of time, if not more time, than using a motorized tool like an angle grinder or a plasma cutter. The hammer should have course beat using any other object to break down a wall, but 2 hits to get through a wall feels insanely fast.

About 5, before, for a regular wall. Reinforced wall is upwards of 30 I believe

Comment on lines 158 to 159
else if (I.tool_behaviour == TOOL_SLEDGEHAMMER)
dam = 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt really need to be amazing at busting thick steel walls. its already is very good at breaking airlocks and windows. But if you really want it to do extra damage do logic similar to the mining tool, as a multiplier, but really shouldn't be more then like 1.5 or 2x
Also your sledge gets the mining tool trait so it wont ever reach this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to completely circumvent the need for REAL breaching tools (angle grinders and breaching charges)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do 150, which would make cheapass normal walls go down in 3 hits but have reinforced walls still take longer than breaching tools.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's still 5x what the normal damage is. To me that just like weirdly strong. like its virtually magic to be that much better against specifically walls.

Copy link
Contributor Author

@generalthrax generalthrax Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big complaint about the breaching sledgehammer (from practically all its users) is that it is ineffective at breaching even thinly plated normal walls (which can be swiftly destroyed using guns like shotguns). What would you suggest would be better in a way that is still worth using?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irl a sledgehammer would not do functionally anything to anything but thin plated metal. But I've drilled through metal walls with a combat knife. I would still consider it to be far stronger then it realistically has any business being. Again you can toss like a 2x multi on it i just think it really doesn't need to be THAT strong.

Copy link
Contributor

@Apogee-dev Apogee-dev Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the issue of shotguns breaching walls easily is better approached by nerfing incidental bullet damage to walls (read: give walls enough armor to make everything that isn’t a rifle or hefty melee weapon like a sledge or axe do basically nothing, or even kludge in a flat damage reduction) than by buffing sledges. Under no circumstances should they outperform grinders and the like, especially on walls (they’re more for airlocks honestly)

@DIB-DOG
Copy link
Contributor

DIB-DOG commented Feb 27, 2025

How many hits was it before this change? Even if it’s a “breaching hammer” I feel like manually beating a wall down should take the same amount of time, if not more time, than using a motorized tool like an angle grinder or a plasma cutter. The hammer should have course beat using any other object to break down a wall, but 2 hits to get through a wall feels insanely fast.

About 5, before, for a regular wall. Reinforced wall is upwards of 30 I believe

5 swings for a normal wall sounds about right to me, tbh. 30 for a reinforced though, yeah, that’s too much. I guess my biggest concern comes from looking to a PVP scenario, where most ships are made of normal walls, this would without a doubt be the fastest hull ripping device available, and it’s ultimately a hand tool.

@generalthrax
Copy link
Contributor Author

generalthrax commented Feb 27, 2025

Eh. Guess I can go 100. Also I was wrong earlier, it was 10 hits for a normal wall

@@ -28,7 +28,7 @@
if(!proximity)
return
if(HAS_TRAIT(src, TRAIT_WIELDED)) //destroys windows and grilles in one hit
if(istype(A, /obj/structure/window) || istype(A, /obj/structure/grille))
if(istype(A, /obj/structure/window) || istype(A, /obj/structure/grille) || istype(A, /obj/structure/girder))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure if its a girder it does a check for TOOL_SLEDGEHAMMER

Comment on lines 158 to 159
else if (I.tool_behaviour == TOOL_SLEDGEHAMMER)
dam = 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irl a sledgehammer would not do functionally anything to anything but thin plated metal. But I've drilled through metal walls with a combat knife. I would still consider it to be far stronger then it realistically has any business being. Again you can toss like a 2x multi on it i just think it really doesn't need to be THAT strong.

@@ -155,6 +155,8 @@
dam = 20
else if(I.tool_behaviour == TOOL_MINING)
dam *= (4/3)
else if (I.tool_behaviour == TOOL_SLEDGEHAMMER)
dam = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and again you need to do it as a multiplier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you do it as a multiplier? The author of destructible walls suggested I do it this way.

@Erikafox
Copy link
Contributor

why not just port demolition_mod

@generalthrax
Copy link
Contributor Author

generalthrax commented Feb 28, 2025

Thats a thing?

@@ -155,6 +155,8 @@
dam = 20
else if(I.tool_behaviour == TOOL_MINING)
dam *= (4/3)
else if (I.tool_behaviour == TOOL_SLEDGEHAMMER)
dam = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dam = 100
dam *= 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted it to specifically be 100 so it could also destroy mineral rock walls since I don't know how to make it both do extra damage to walls and also be a mining tool at the same time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt really need to 1 shot mineral rock walls. its not a dedicated pickaxe.

Copy link
Contributor Author

@generalthrax generalthrax Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original concept that Apogee and us agreed on was a joint breaching-mining tool for marauders. In fact, it is currently mapped into fullmerged NGR and Hardliner ships as a mining tool.

@FalloutFalcon
Copy link
Member

Thats a thing?

image

@FalloutFalcon
Copy link
Member

gonna wait on erika's deconstruct modifier pr before i continue reviewing this.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Merge Conflict Use Git Hooks, you're welcome.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants