chore: improve mysql readiness checks #2397
Open
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the docker-compose.yml file by enforcing healtchecks between mysql and the trillian services. It also increases the timeouts for the healthchecks.
See https://docs.docker.com/reference/dockerfile/#healthcheck
This improves the developer experience, so we don't see so many startup errors for the trillian services, like
Testing process
On a personal machine, it can take 90s for mysql to be ready.
trillian-log-signer starts cleanly
Release Note
Better timeouts and readiness checks in docker-compose.yml.
Documentation