Add (selftest) virtual environment management #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
changed the title
|
* self test requirements are separated into sigstore-requirements.txt * Makefile now creates a separate venv for selftest sigstore client * sigstore-python-conformance expects to find the sigstore binary in the venv * workflow is simplified similarly Signed-off-by: Jussi Kukkonen <[email protected]>
This hopefully makes it clearer what it is. same goes for selftest-requirements.txt Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
virtual-env-management
branch
from
3a6d53c to
39440fd
Compare
|
|
I think this might need changes since #192 was merged before this EDIT: nah, it actually looks compatible to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two goals:
Changes:
selftest-requirements.txt(similar unusedtools/requirements.txtwas removed)selftest-envfor selftest sigstore clientselftest-envThe fact that sigstore-python-conformance now requires the venv to exist is a bit restricting: but it works and makes issues like the sigstore-protobuf-specs upgrade in #194 locally debuggable -- if other options are needed later on it will be easy to add a env variable or something to override the binary location