Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX correct userform reference & avoid submit errors #869

Merged

Conversation

NightJar
Copy link
Contributor

"Uncaught TypeError: Cannot read property 'data' of undefined
Was being reported when attempting to submit a form, which would
then trigger the "are you sure" functionality which should only
show when attempting to browse away from a page when changes to the
form have been made.

"Uncaught TypeError: Cannot read property 'data' of undefined
Was being reported when attempting to submit a form, which would
then trigger the "are you sure" functionality which should only
show when attempting to browse away from a page when changes to the
form have been made.
@NightJar
Copy link
Contributor Author

Warning: as yet untested. Hopefully a fix for #868 - but as I cannot reproduce I would like @extravio, @guyvanbael, or @purplespider to give it a test for me.

@NightJar
Copy link
Contributor Author

NightJar commented Mar 24, 2019

:( The Travis CI builds are faililng... however this is only a single case, and only because of phpcs incorrectly identifying the expected number of spaces for indentation.
I've raised an issue here, and will not be attempting to fix the build.
squizlabs/PHP_CodeSniffer#2459


Confirmed and already fixed by phpcs team, due with the 3.4.2 release

which is expected reasonably soon.

:)

@kinglozzer
Copy link
Member

LGTM! I wonder if that phpcs issue is also the cause of the weird PHP errors we’ve been seeing in framework/other modules...

@robbieaverill
Copy link
Contributor

Yeah it’ll affect all of our builds until they release the next patch version

@extravio
Copy link

@NightJar Tested successfully.
This fixes both the "Uncaught TypeError: Cannot read property 'data' of undefined" and issue #868

@robbieaverill robbieaverill merged commit 3e450c0 into silverstripe:5.3 Mar 25, 2019
@robbieaverill robbieaverill deleted the pulls/5.3/submit-no-errors branch March 25, 2019 20:13
@NightJar
Copy link
Contributor Author

Thanks for confirming @extravio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants