-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etags should be in double quotes #2
Comments
Turns out this was a problem with starlette too... recently fixed (encode/starlette#2298 (comment)). This will be fixed in >v0.5.0 (and >0.5.0 of simple-repository core also) |
Fixed in v0.6.0. Thanks for the nit - it is always good to improve this stuff. |
Note that it is also necessary to update |
pelson
added a commit
to simple-repository/simple-repository
that referenced
this issue
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
minor nit:
simple-repository-server/simple_repository_server/routers/simple.py
Line 135 in fe35366
See the spec:
https://www.rfc-editor.org/rfc/rfc9110#field.etag
I've literally once, ever, seen this be an issue, with virgin media's web-to-cable-tv caches back in 2001. But that client just dropped responses with misformatted etags on the floor.
The text was updated successfully, but these errors were encountered: