Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded color? #26

Open
avonmoll opened this issue Nov 28, 2016 · 3 comments
Open

Hard-coded color? #26

avonmoll opened this issue Nov 28, 2016 · 3 comments

Comments

@avonmoll
Copy link

With the following custom scheme:
image

I still have some light-purple colors showing:
image

Is this the intended behavior?

@simurai
Copy link
Owner

simurai commented Nov 29, 2016

No, the conditional... should also have the Uno hue (orange).

Could you paste that code snippet here? I'll try to reproduce it. And also, what's the grammar (language shown in the bottom right of the status-bar)?

@avonmoll
Copy link
Author

The grammar is Python. As a slight aside, would it be possible to allow the user to set a custom background color of the theme? It's possible to simply change the stylesheet, but then user must change stylesheet back when switching to other themes. Just a thought!

def compute_empirical_conditional_distribution(var1_values, var2_values):
    """
    Given two sequences of values (corresponding to samples from two
    random variables), compute the empirical conditional distribution of
    the first variable conditioned on the second variable.

    Inputs
    ------
    - var1_values: list (or 1D NumPy array or some other iterable) of values
        sampled from, say, $X_1$
    - var2_values: list (or 1D NumPy array or some other iterable) of values
        sampled from, say, $X_2$, where it is assumed that the i-th entries of
        `var1_values` and `var2_values` co-occur
    Output
    ------
    - conditional_distributions: a dictionary consisting of dictionaries;
        `conditional_distributions[x_2]` should be the dictionary that
        represents the conditional distribution $X_1$ given $X_2 = x_2$
    """
    conditional_distributions = {x2: {} for x2 in set(var2_values)}

    # -------------------------------------------------------------------------

simurai added a commit to simurai/duotone-syntax that referenced this issue Dec 2, 2016
Will be used by all languages when no other scope is defined.

Ref: simurai/duotone-dark-syntax#26
@simurai
Copy link
Owner

simurai commented Dec 2, 2016

Thanks.. I can reproduce this too and should be fixed with the next update.

As a slight aside, would it be possible to allow the user to set a custom background color of the theme? It's possible to simply change the stylesheet, but then user must change stylesheet back when switching to other themes.

Well, you could limit it to just this theme by adding .theme-duotone-dark-syntax in front. Like this:

.theme-duotone-dark-syntax atom-text-editor::shadow,
.theme-duotone-dark-syntax atom-text-editor {
  background-color: darkred;
}

Although changing it in your styles.less file might make it not match everywhere. For example the active tab will probably be different.

Here a theme where you can change everything: https://github.com/simurai/chameleon-ui + https://github.com/simurai/chameleon-syntax. But both need to be installed to make it work. It's still kinda experimental though.. that's why it's not published. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants