Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async iterables #16

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Support async iterables #16

merged 3 commits into from
Aug 13, 2020

Conversation

papb
Copy link
Contributor

@papb papb commented Aug 13, 2020

This PR adds support for converting async iterables into readable streams.

Note: build is failing for Node 8, so I guess you'll want to make a major version bump first dropping support for it?

@@ -1,6 +1,6 @@
# into-stream [![Build Status](https://travis-ci.org/sindresorhus/into-stream.svg?branch=master)](https://travis-ci.org/sindresorhus/into-stream)

> Convert a string/promise/array/iterable/buffer/typedarray/arraybuffer/object into a stream
> Convert a string/promise/array/iterable/asynciterable/buffer/typedarray/arraybuffer/object into a stream
Copy link
Contributor Author

@papb papb Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure of which casing to use here...

Also don't forget to update this repository's About info with this as well :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

@sindresorhus sindresorhus merged commit 62f1ed7 into sindresorhus:master Aug 13, 2020
@sindresorhus
Copy link
Owner

Nice work 👍🏻

@papb papb deleted the support-async-iterables branch August 13, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants