Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snippet in
example.js
doesn't work on windows platform with this setup:(from git-bash)
For what I read from docs, this is caused by windows that require some adjustments on the
spawn
command in order to works properly:childProcess.spawn(
${result.binary}.cmdor
childProcess.spawn(${result.binary}.exe
shell: process.platform === 'win32'
parameter so the command will be executed in a standalone shallA related issue on node.js (since vscode is an electron app)
nodejs/node#15217
I would appreciate your thought about this PR.
Thank you very much