-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub Actions workflow #447
Conversation
Added timeout to
|
Thanks for working on this. Seems like tests are still failing. |
Yes there's one more issue to fix. WIP |
The problem is that now the PNG image is 24 bit. But the tests consider it to be 32 bit with alpha channel. I don't know if it was like that in the past or when this changed. The fix is easy. I will add a new commit today. |
Now the PNG image is properly treated as 24 bit. And in tests I changed the black color to more complex to validate the numbers. Having all zeros for black looks too simple or a case when it's uninitialized. |
@sindresorhus it's OK now and ready for review. If you merge this PR, then I would like to submit a new PR that updates the dependencies that are quite outdated. |
|
commit 93d7574 Author: Ramil Valitov <[email protected]> Date: Wed Feb 5 15:15:39 2025 +0300 Fix GitHub Actions workflow (sindresorhus#447)
This PR fixes the tests workflow:
main.yml
that usesubuntu-latest
and error:The approach is the most simple: disable the feature of AppArmor to be able to run the tests.
ava
timeout message:cookie
tests because of incorrect PNG bits per pixel processing.