Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make types required & update docs & refactor #3

Merged
merged 13 commits into from
Feb 28, 2024

Conversation

Saiv46
Copy link

@Saiv46 Saiv46 commented Feb 23, 2024

Checklist:

  • Actors
  • Activities
  • Collections
  • Documents
  • Objects

Closes #2

@Saiv46 Saiv46 marked this pull request as ready for review February 25, 2024 15:01
@siranweb siranweb self-requested a review February 25, 2024 17:32
@siranweb siranweb changed the base branch from main to release-1.1.0 February 26, 2024 14:45
Copy link
Owner

@siranweb siranweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thank you. Just a few minor changes

@siranweb siranweb changed the title Make types required Make types required & update docs & refactor Feb 26, 2024
@Saiv46 Saiv46 requested a review from siranweb February 28, 2024 07:22
@siranweb siranweb merged commit 0504cb7 into siranweb:release-1.1.0 Feb 28, 2024
siranweb added a commit that referenced this pull request Feb 28, 2024
* Make types required & update docs & refactor (#3)

* Add types & docs for actors

* Add type field to documents

* Move APArticle to documents

* Type for APArticle

* Move APNote

* Set type to APCollection(Page)

* Refactor APOrderedCollection(Page)

* Missed actor docs

* Add types (simple activities)

* Added docs to Activity

* Rename ./common to ./objects

* Object types

* Fix APQuestion

* Add APRoot and remove context field from object (#5)

* docs & chore 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make type required
2 participants