Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrolling to float layer by addFloatLayer #9123

Closed
3 tasks done
suka233 opened this issue Sep 6, 2023 · 2 comments
Closed
3 tasks done

Add scrolling to float layer by addFloatLayer #9123

suka233 opened this issue Sep 6, 2023 · 2 comments
Assignees
Milestone

Comments

@suka233
Copy link

suka233 commented Sep 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

插件的api: addFloatLayer,创建的悬浮窗口,目前发现有如下两个问题:
1.如果悬浮窗口内的内容过长,无法展示纵向的滚动条,导致内容看不完全
2.如果手动调整悬浮窗口的大小,那么悬浮窗口会自动将高度铺满内容区,并且无法上下移动,只能左右移动
以上两个bug在如下gif动图可以看出来:
floatBug

Expected result

1.希望通过addFloatLayer创建出来的悬浮窗口可以像普通的块引用悬浮预览窗口一样,可以任意拖动,并且有纵向滚动条
2.还想请问一下,addFloatLayer的这两个参数是啥意思
image

Screenshot or screen recording presentation

No response

Version environment

- Version: v2.10.3
- Operating System: windows11
- Browser (if used):

Log file

暂无

More information

No response

@suka233 suka233 changed the title add addFloatLayer Api创建的悬浮窗口,长内容显示不完全 Sep 6, 2023
@zxhd863943427
Copy link
Contributor

targetElement是用来定位的,大概就是填了啥,浮窗就会到那个位置。
defIds我也不理解干啥用。
其实在protyle出来后,还是自己写浮窗装protyle更能自定义一点。

@Vanessa219
Copy link
Member

defIds 传入后会红框文字会高亮
image

@Vanessa219 Vanessa219 self-assigned this Sep 7, 2023
@Vanessa219 Vanessa219 added this to the 2.10.4 milestone Sep 7, 2023
@Vanessa219 Vanessa219 changed the title addFloatLayer Api创建的悬浮窗口,长内容显示不完全 Add scrolling to float layer by addFloatLayer Sep 7, 2023
Vanessa219 added a commit that referenced this issue Sep 7, 2023
EightDoor added a commit to EightDoor/siyuan that referenced this issue Sep 7, 2023
* commit '097501c84c56d5a0083a5bd29fc7efe686ee70b9': (82 commits)
  🎨 fix siyuan-note#9123
  🐛 fix siyuan-note#9135
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Update av
  🐛 siyuan-note#9126
  💄
  🐛 The image file name is too long and truncated abnormally Fix siyuan-note#9129
  💄
  🎨 The cloud sync directory name (Bucket) supports up to 63 characters siyuan-note#9130
  🔥 Revert Improve block loading performance on Windows/Linux/macOS amd64 arch Fix siyuan-note#9131
  💄
  📱 fix siyuan-note#9113
  📱 fix siyuan-note#9127
  📱  fix siyuan-note#9111
  📱  fix siyuan-note#9111
  🚨
  ⚡ Improve block loading performance on Windows/Linux/macOS amd64 arch siyuan-note#9084
  🎨 Update text
  ...
EightDoor added a commit to EightDoor/siyuan that referenced this issue Sep 7, 2023
* develop: (82 commits)
  🎨 fix siyuan-note#9123
  🐛 fix siyuan-note#9135
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Update av
  🐛 siyuan-note#9126
  💄
  🐛 The image file name is too long and truncated abnormally Fix siyuan-note#9129
  💄
  🎨 The cloud sync directory name (Bucket) supports up to 63 characters siyuan-note#9130
  🔥 Revert Improve block loading performance on Windows/Linux/macOS amd64 arch Fix siyuan-note#9131
  💄
  📱 fix siyuan-note#9113
  📱 fix siyuan-note#9127
  📱  fix siyuan-note#9111
  📱  fix siyuan-note#9111
  🚨
  ⚡ Improve block loading performance on Windows/Linux/macOS amd64 arch siyuan-note#9084
  🎨 Update text
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants