Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin weight to fix keyring service dependency #4

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

iignatevich
Copy link
Contributor

No description provided.

@iignatevich iignatevich force-pushed the fix_missing_keyring_service branch from 7c80d9d to 8213f05 Compare February 29, 2024 16:15
@davidferlay davidferlay marked this pull request as ready for review March 1, 2024 11:40
@davidferlay davidferlay merged commit c7c7912 into main Mar 1, 2024
@davidferlay
Copy link
Contributor

dferlay
so I take it each plugin using keyring should be set with a different weight ?

iignatyev
yes, keyring is zero, so dependent plugin should have a bigger number.
there is todo in launchr to handle such deps in more proper way, but not priority right now

dferlay
Like with a different system than weight ?

iignatyev
yes, identify plugin dependencies and automatically handle it instead setting weights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants