Adding New Level: Lua Metatable hooks #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkcso
reviewed
Mar 14, 2025
There was a problem hiding this comment.
@TheDarkThief Thanks for your work! I left comments to improve it and accept it, good job man!
Season-3/Level-1/code.lua
Outdated
|
|
||
|
|
||
| --- Generates a bitmap image | ||
| -- @param request: The table which we will populate with images |
There was a problem hiding this comment.
I understand what you try to say but please rewrite it in a more explanatory way, such as for example that the table will contain pixels for the image that will be populated and it's being represented as a table.
There was a problem hiding this comment.
Went into a bit more depth in the comment
|
I've made the requested changes, as well as switch to the Busted library making it easier to setup Github CI as well as make the error messages a bit clearer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new level demonstrating Lua metatables, and how a malicious actor can hook into them
Changes
Created a level where a user requests the client to populate a table, where a malicious actor gains remote code execution due to improper sanitation.
Task list