Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

chore: Upgrade module path for v2 #383

Merged
merged 4 commits into from
Jan 24, 2024
Merged

chore: Upgrade module path for v2 #383

merged 4 commits into from
Jan 24, 2024

Conversation

Eric-Warehime
Copy link
Contributor

@Eric-Warehime Eric-Warehime commented Jan 23, 2024

We need to upgrade the module path from github.com/skip-mev/block-sdk => github.com/skip-mev/block-sdk/v2 otherwise when you run go get github.com/skip-mev/[email protected] you'll get the following error

go: github.com/skip-mev/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/skip-mev/block-sdk/v2")

Note: we should not backport this to v1.

Closes BLO-806

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (234e2ff) 52.75% compared to head (feabca2) 52.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   52.75%   52.75%           
=======================================
  Files          48       48           
  Lines        2337     2337           
=======================================
  Hits         1233     1233           
  Misses       1014     1014           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eric-Warehime Eric-Warehime merged commit acff9d0 into main Jan 24, 2024
13 checks passed
@Eric-Warehime Eric-Warehime deleted the eric/mod-upgrade branch January 24, 2024 17:06
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
(cherry picked from commit acff9d0)

# Conflicts:
#	abci/abci_test.go
#	abci/checktx/check_tx_test.go
#	abci/utils_test.go
#	block/base/mempool_test.go
#	block/base/tx_priority_test.go
#	block/lane_test.go
#	block/mempool.go
#	block/mempool_test.go
#	block/mocks/lane_fetcher.go
#	tests/app/app.go
#	tests/app/config.go
#	tests/e2e/block_sdk_e2e_test.go
#	tests/e2e/go.mod
#	tests/integration/integration_test.go
#	tests/integration/network/auction_test.go
#	tests/integration/network/network_test.go
#	testutils/keeper/keeper.go
#	testutils/mempool/mempool.go
#	testutils/networksuite/networksuite.go
#	x/blocksdk/client/cli/query.go
#	x/blocksdk/client/cli/tx.go
#	x/blocksdk/keeper/genesis.go
#	x/blocksdk/keeper/grpc_query.go
#	x/blocksdk/keeper/grpc_query_test.go
#	x/blocksdk/keeper/keeper.go
#	x/blocksdk/keeper/keeper_test.go
#	x/blocksdk/keeper/msg_server.go
#	x/blocksdk/keeper/msg_server_test.go
#	x/blocksdk/module.go
#	x/blocksdk/types/lane_test.go
#	x/blocksdk/types/msgs_test.go
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
(cherry picked from commit acff9d0)

# Conflicts:
#	abci/abci_test.go
#	abci/checktx/check_tx_test.go
#	abci/checktx/mev_check_tx.go
#	abci/utils_test.go
#	block/base/mempool_test.go
#	block/base/tx_priority_test.go
#	block/lane_test.go
#	block/mempool.go
#	block/mempool_test.go
#	block/mocks/lane_fetcher.go
#	block/service/service_test.go
#	tests/app/app.go
#	tests/app/config.go
#	tests/app/testappd/cmd/root.go
#	tests/app/testappd/cmd/testnet.go
#	tests/e2e/block_sdk_e2e_test.go
#	tests/e2e/go.mod
#	tests/integration/integration_test.go
#	tests/integration/network/auction_test.go
#	tests/integration/network/network_test.go
#	testutils/keeper/keeper.go
#	testutils/mempool/mempool.go
#	testutils/networksuite/networksuite.go
#	testutils/utils.go
#	x/auction/types/mocks/staking_keeper.go
#	x/blocksdk/client/cli/query.go
#	x/blocksdk/client/cli/tx.go
#	x/blocksdk/keeper/genesis.go
#	x/blocksdk/keeper/grpc_query.go
#	x/blocksdk/keeper/grpc_query_test.go
#	x/blocksdk/keeper/keeper.go
#	x/blocksdk/keeper/keeper_test.go
#	x/blocksdk/keeper/msg_server.go
#	x/blocksdk/keeper/msg_server_test.go
#	x/blocksdk/module.go
#	x/blocksdk/types/lane_test.go
#	x/blocksdk/types/msgs_test.go
Eric-Warehime added a commit that referenced this pull request Jan 24, 2024
* chore: Upgrade module path for v2 (#383)

(cherry picked from commit acff9d0)

# Conflicts:
#	abci/abci_test.go
#	abci/checktx/check_tx_test.go
#	abci/utils_test.go
#	block/base/mempool_test.go
#	block/base/tx_priority_test.go
#	block/lane_test.go
#	block/mempool.go
#	block/mempool_test.go
#	block/mocks/lane_fetcher.go
#	tests/app/app.go
#	tests/app/config.go
#	tests/e2e/block_sdk_e2e_test.go
#	tests/e2e/go.mod
#	tests/integration/integration_test.go
#	tests/integration/network/auction_test.go
#	tests/integration/network/network_test.go
#	testutils/keeper/keeper.go
#	testutils/mempool/mempool.go
#	testutils/networksuite/networksuite.go
#	x/blocksdk/client/cli/query.go
#	x/blocksdk/client/cli/tx.go
#	x/blocksdk/keeper/genesis.go
#	x/blocksdk/keeper/grpc_query.go
#	x/blocksdk/keeper/grpc_query_test.go
#	x/blocksdk/keeper/keeper.go
#	x/blocksdk/keeper/keeper_test.go
#	x/blocksdk/keeper/msg_server.go
#	x/blocksdk/keeper/msg_server_test.go
#	x/blocksdk/module.go
#	x/blocksdk/types/lane_test.go
#	x/blocksdk/types/msgs_test.go

* Fix merge

* update

---------

Co-authored-by: Eric Warehime <[email protected]>
Co-authored-by: aljo242 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants