fix(provider): allow providers to choose how they parse ports #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zygimantass
requested review from
davidterpay,
nivasan1,
aljo242 and
Eric-Warehime
as code owners
Zygimantass
force-pushed
the
zygis/explicit-protocol-in-port
branch
2 times, most recently
from
b208886 to
7acf7f8
Compare
aljo242
reviewed
Jan 26, 2024
feat(provider): add DigitalOcean provider
Zygimantass
merged commit 4bba0c2
into
zygis/use-docker-id-instead-of-name
7 checks passed
Zygimantass
added a commit
that referenced
this pull request
Jan 30, 2024
fix(provider): allow providers to choose how they parse ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Other providers like DigitalOcean do not have the ability to differentiate between TCP and UDP exposed ports. As such, we remove the need to specify which protocol you want the port for in the string and leave that functionality upto the provider.