Add debug logs #71
Merged
Add debug logs #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
requested review from
Zygimantass,
davidterpay,
nivasan1 and
aljo242
as code owners
aljo242
reviewed
Jan 29, 2024
Zygimantass
force-pushed
the
eric/add-debug-logs
branch
from
456e018 to
1ae26dd
Compare
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add debug logs on any commands run on the nodes.
Most of the commands don't actually return non-zero when they fail--they all just log things to stderr. Adding debug logs gives much better visibility.
Also uncommented a cleanup function. And removed
--homefromcollect-gentxssince thenode::BinCommandfunction already wraps the command with the home flag.