fix: Increase timeout for the Chromecast to connect to the HTTP server #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current 10 second wait isn't long enough on slow networks (like my wifi network at home!). Let's wait 30 seconds instead.
skorokithakis
approved these changes
Sep 21, 2020
skorokithakis
changed the title
|
Looks good, thanks! I edited the title so the changelog credits you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 10 second wait isn't long enough on slow networks (like my wifi network at home!). Let's wait 30 seconds instead.
Fixes #294.
I was unable to reproduce the issue again with the 10 second wait (typical!), but I was able to repro by setting the timeout lower.
Thanks!