feat: Introduce StandardSchemaV1 interface in Skunkteam Types #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooked into the existing Valid/Invalid Conversion tests.
untio11
force-pushed
the
robin/introduce-standard-schema
branch
from
ecb6e78 to
a1cafb3
Compare
untio11
force-pushed
the
robin/introduce-standard-schema
branch
from
b86f597 to
3f73f39
Compare
|
After merging and releasing this PR, open a PR to merge updated StandardSchema readme from our fork upstream. |
pavadeli
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Awesome work! I'm suggesting a slightly toned down version of the messages in the issues. If you agree with my changes then you can merge at will.
Note that this will merge into the next branch. After merging this PR, I think it's time to release another major version.
pavadeli
added a commit
that referenced
this pull request
Feb 18, 2025
* feat: Introduce StandardSchemaV1 interface in Skunkteam Types Hooked into the existing Valid/Invalid Conversion tests. * chore: Forgot to run pre-pr command * suggesting simpler messages in standard validate --------- Co-authored-by: Paco van der Linden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooked into the existing Valid/Invalid Conversion tests.