use embbedded configs by default for skywire cli config gen
#1941
+57
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the external
dmsghttp-config.json&services-config.jsonwill not be read, by default. The flag defaults for the path to these configs is now an empty string, and where the config would have been read from the disk has been replaced by reading the embedded config.The user may specify a path to the config, and in doing so override the embedded deployment defaults with their own custom deployment config.
It's now no longer necessary to include these configs in the binary release.
Note also: the embedded defaults may be printed with
skywire svc confandskywire dmsg conf; further obviating the need for separate files.