Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip 22 breaks our dependencies #2611

Merged
merged 3 commits into from
Feb 1, 2022
Merged

pip 22 breaks our dependencies #2611

merged 3 commits into from
Feb 1, 2022

Conversation

mcoughlin
Copy link
Contributor

I think the release of pip 22 broke our dependency installation...

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 30, 2022
@github-actions github-actions bot added the workflows Pull requests that update GitHub Actions workflows label Jan 30, 2022
@mcoughlin mcoughlin requested a review from stefanv January 30, 2022 23:38
@mcoughlin
Copy link
Contributor Author

@stefanv Any ideas what to do about this one...?

@profjsb
Copy link
Collaborator

profjsb commented Jan 31, 2022

Are you also getting the dependency failures on your local machine with pip22? I'm totally fine with pinning pip.

@mcoughlin
Copy link
Contributor Author

No I cant get it to fail locally for some reason, but that also seems to be a common issue:
pypa/pip#10851

@profjsb
Copy link
Collaborator

profjsb commented Jan 31, 2022

Looks like the fix is coming out very soon (22.0.2) pypa/pip@347d190

@profjsb profjsb merged commit 7155686 into skyportal:master Feb 1, 2022
@stefanv
Copy link
Collaborator

stefanv commented Feb 1, 2022

We should revert this patch once the new pip is out.

@mcoughlin mcoughlin deleted the pip branch August 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file workflows Pull requests that update GitHub Actions workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants