Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update packaging notation for local development requirements #1271

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Mar 13, 2025

Summary

This PR updates the maintainers_guide.md packaging step for local build developments to match a recent change to the slack_sdk notes 📚

Testing

An expanded version of these line can be found with pip freeze!

Category

  • Document pages under /docs
  • maintainers_guide.md
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimeg zimeg added the docs Improvements or additions to documentation label Mar 13, 2025
@zimeg zimeg self-assigned this Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (9c26945) to head (2cc020e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg requested a review from WilliamBergamin March 13, 2025 22:31
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯 thanks for standardizing this 🥇

@WilliamBergamin WilliamBergamin merged commit 4c237fe into main Mar 14, 2025
14 checks passed
@WilliamBergamin WilliamBergamin deleted the zimeg-docs-maintainers-guide-build-pip branch March 14, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants